napa182
Comments: 742
 

you should make it treat the text as plane text cuz you can have it do commands. you should use the n switch so the line read in will not be evaluated and will be treated as plain text.

Code:

$read(Quotes.txt,n)

and you dont need to use the /

napa182
Comments: 742
 

oh and if you want to count the quotes you can use

Code:

$lines(Quotes.txt)

no need for Variables

Corrosive
Comments: 5
 

I don't feel like I need to change anything about that at this time, I might update the script soon with way more stuff.

RubixCube
Comments: 53
 

Pros:
- It seems to work, although I have not tested this fully as of now

Cons:
- Scripting is terrible
- Constantly have to filter <nick>
- Lack of error checking

Quite a bit. No need of halts, for the == $null simple use a !$read(etc), (as said before) just use $lines(quotes.txt) because it's useless to have a variable, remove /'s, provide things such as if ($2) to error check, also: for things such as != $null you don't need those just use the actual identifier or if statement.

Also, you should, as a script writer, accept comments of others and fix mistakes. If you 'don't feel like editing' the snippet, don't expect a high score. :)

I would take a look @ the other ones on here and learn a little from them. For example, napa182's quote system. That's efficient and it has a lot of variety. I'm not saying deliberately take things out of snippets but just take a look on how others approached it. Maybe you'll find many more ideas.

napa182
Comments: 742
 

im just saying if Ur bot is op'ed someone can use Ur bot to op them selvs with Ur quote script thats why it's a good idea to use the n switch. But what ever if you dont want to listen then you risk a channel take over with this script.

napa182
Comments: 742
 

oh and like RubixCube said

Quote:

Also, you should, as a script writer, accept comments of others and fix mistakes. If you 'don't feel like editing' the snippet, don't expect a high score. :)

mountaindew
Comments: 1,380
 

if u delete all quotes and then try to read one itll give an error

mountaindew
Comments: 1,380
 

and u can just do

Code:

on *:text:*:#:{   if ($nick == <nick>) {     if ($1 == w/e) w/e     if ($2 == sometin) w/e   }   else msg $chan u aint allowed to do dis }

Corrosive
Comments: 5
 

Napa, they can't use it like that because I have tried to do it.

napa182
Comments: 742
 

Im still saying to use the n switch, and like mountaindew said when you delete all quotes it gives an error after you !addquote, and then try to use !quote 1.. Cuz you have it( set %quotes 0 ) on !DeleteAllQuotes, but you dont have it( inc %quotes ) when you !addquote. Thats why you should just use $lines(Quotes.txt) to keep count of the quotes. We are just trying to help...

mountaindew
Comments: 1,380
 

Quote:

Napa, they can't use it like that because I have tried to do it.

;) theres nothing wrong with it