Comments

Nomader
Comments: 5
 

the >> button causes mirc to crash.

Hydroxide
Comments: 9
 

This is so awesome. Can someone tell me how to edit it so that I can scroll sideways on the songs list?

RussellReal
Comments: 41
 

I'm okay, and you? :)

brinxy
Comments: 30
 

For most of the functionality, you did a good job. Would be excellent to add a directory without making a new playlist. I would also like to see an add file and remove file option because I have quite a bit of songs loaded in my directory. That would make the playlist option better.

For the coding, not so good. I'm surprised that it makes it easier for you to understand. /'s usually tend to make coding look sloppy and confusing in my opinion. I'd strongly recommend you remove them, but that isn't significant. You also lack error checking. (Opening dialogs is an example.)

For the way you handle your files, I think you can improve upon that as well. Your writeini can't support 64k or more (going back to large directories). I'd use hash tables, or just make the writeini command /writeini -n.

I'd like to see a scroll bar instead of two buttons to seek though the song. That way the user could get more exact with the position. It would be good to make your options into a separate dialog, the actual mp3 dialog itself would look a lot neater. Another thing I noticed in a lot of the mp3s on here, when they have volume seeking in their snippet, is that they skip to a certain percentage instead of scrolling regularly. If you could change your current buttons to a scrollbar as well, that'd be great.

Perhaps add an id3 editor, and more options as to the display. (Such as size and album for example.)

After that novel, I'd have to say you put a lot of effort and tried to create a decent mp3 player. You did, and I credit you for that. If you just included some updates and fixes, you'd have an even better snippet. Very good job.

mountaindew
Comments: 1,422
 

sorry, forgot to rate it :P

8/10

spitfire3292
Comments: 36
 

Also if you guys could rate this I would def. appreciate it :)

spitfire3292
Comments: 36
 

Hehe. You will by the end of the year or you will in trig def. It should prove useful to many in trig or pre-calc.

spitfire3292
Comments: 36
 

And how did you like the player itself? lol. Sorry you don't like the taste of music I put up there. It was just the first couple songs in my playlist :)

SLS10
Comments: 35
 

Though ACDC is epic

SLS10
Comments: 35
 

Uh, this seems random. But some of the songs on that sample playlist are horrible travesties.

mountaindew
Comments: 1,422
 

lol i didnt know it was two years ago, i probably have a lot of old snippets w/ silly stuff too

u dont have to change it, but just for reference, use .msg and .notice instead of halting :)

spitfire3292
Comments: 36
 

mountaindew you do realize this was almost 2 years ago. I just began scripting lol. I think I'm a bit better at scripting now. If you reallly want me to rewrite it i will lol

mountaindew
Comments: 1,422
 

im in geo honors, havent learned it yet :P

mountaindew
Comments: 1,422
 

the bugs rnt rly important, its just for when u click stuff when ur not supposd to :)

mountaindew
Comments: 1,422
 

a little advide:

for comments in a script, do

Code:

/* the comments that you write in the script */

OR

Code:

;The commants ;that you ;write in ;the script

also, when u do

Code:

/if (!$2) { msg $chan Give my bot a rating 1-10 : 10 being the highest. To do so type !rate ə-10> }   /elseif ($2) {

no need for elseif ($2), just else {
u also dont need the if !$read, jsut else
and u can use isnum to see if its a num 1-10

Code:

if ($2 isnum 1-10) {

also, as acid said, u should consider doing a hash table or an ini, but nice idea

spitfire3292
Comments: 36
 

Well if you've taken geometry or trigonometry you will have learned about the unit circle and this deals with that. If you haven't taken geo or trig it's basically useless lol.

spitfire3292
Comments: 36
 

Thanks :) Yeah there just little bugs. It's simple to fix, just add an if (!$server) { halt } kinda deal. I can't be annoyed t o update it right this second since I'm kind of busy but when I get some spare time i'll update it. And once again, thanks and I'm glad you like it :)

mountaindew
Comments: 1,422
 

what exactly duz this do?

mountaindew
Comments: 1,422
 

no problem, i have 0 experience with like drawing in windows and shoot like that ;)

mountaindew
Comments: 1,422
 

use .timer so it duznt show in status

when u delet a directory, i dont get why u have ppl input the playlist

thats about the only stuff i found bad about it, i love this, u did a great job

on this one, i can actually tell what the features do, and i love the idea of how u output song details where u can customize it

i also like how u say the volume percent in the title, very unique and helpful, i was gonna say u should display current volume, but i looked and u did!

i also like how u can fast forward w/ this, and it updates the time in the title even whe u ff/rw

but one thing, when i click >>, and repeat is checked, it goes to the next song and duznt repeat

also, im gettin these errors:

Quote:

* /splay: no such file '.mp3' (line 120, script2.mrc) - * /amsg: not connected to server (line 307, script2.mrc) - * /splay: no such file 'pause' (line 199, script2.mrc)

the splay error comes from when its stopped, and i try to hit pause, and i imagine the amsg is when i click quick msg display, and im not connected;two little bugs.

other than that, i rly like this, u did a great job, and im keepin it on my mirc :P